Buncha changes and fixes

Makefile.am

@@ -1,4 +1,4 @@
-SUBDIRS = src
+SUBDIRS = src include
 
 quark.iso: src/quark-kernel rootfs/boot/grub/grub.cfg
 	mkdir -p rootfs/apps

README.md

@@ -10,7 +10,7 @@ You will need:
 
 To build the kernel for the x86 platform, run:
 - `autoreconf -i`
-- `./configure --host=i686-elf CFLAGS=-ffreestanding LDFLAGS=-nostdlib`
+- `./configure --host=i686-elf --prefix=<your_desired_prefix> --bindir=$(prefix)/apps CFLAGS=-ffreestanding LDFLAGS=-nostdlib`
 - `make`
 
 To generate a bootable disk image, run:

configure.ac

@@ -27,5 +27,5 @@ AC_TYPE_UINT8_T
 
 AM_CONDITIONAL([x86], [test $host = i686-elf])
 
-AC_CONFIG_FILES([Makefile src/Makefile])
+AC_CONFIG_FILES([Makefile src/Makefile include/Makefile])
 AC_OUTPUT

include/Makefile.am

@@ -0,0 +1 @@
+nobase_include_HEADERS = types/status.h types/syscallid.h types/physaddr.h types/syscallarg.h

include/kernel.h

@@ -101,41 +101,41 @@ struct kernel_t
 
 void kernel_initialize(struct boot_info_t *boot_info);
 
-enum error_t set_syscall(int id, int arg_count, int pid, void *func_ptr);
+error_t set_syscall(int id, int arg_count, int pid, void *func_ptr);
 
-size_t do_syscall(enum syscall_id_t id, syscall_arg_t arg1, syscall_arg_t arg2, syscall_arg_t arg3, void *pc, void *stack, unsigned long flags);
+size_t do_syscall(syscall_id_t id, syscall_arg_t arg1, syscall_arg_t arg2, syscall_arg_t arg3, void *pc, void *stack, unsigned long flags);
 
-enum error_t kernel_load_module(struct module_t *module);
+error_t kernel_load_module(struct module_t *module);
 
 unsigned long kernel_current_pid();
 
 struct process_context_t *kernel_current_context();
 
-enum error_t kernel_store_active_context(struct process_context_t *context);
+error_t kernel_store_active_context(struct process_context_t *context);
 
 unsigned long kernel_spawn_process(void *program_entry, int priority, physaddr_t address_space);
 
 struct process_context_t *kernel_advance_scheduler();
 
-enum error_t kernel_terminate_process(size_t process_id);
+error_t kernel_terminate_process(size_t process_id);
 
-enum error_t kernel_create_port(unsigned long id);
+error_t kernel_create_port(unsigned long id);
 
-enum error_t kernel_remove_port(unsigned long id);
+error_t kernel_remove_port(unsigned long id);
 
 unsigned long kernel_get_port_owner(unsigned long id);
 
-enum error_t kernel_send_message(unsigned long recipient, struct message_t *message);
+error_t kernel_send_message(unsigned long recipient, struct message_t *message);
 
-enum error_t kernel_queue_message(unsigned long recipient, struct message_t *message);
+error_t kernel_queue_message(unsigned long recipient, struct message_t *message);
 
-enum error_t kernel_register_interrupt_handler(unsigned long interrupt, signal_handler_t handler, void *userdata);
+error_t kernel_register_interrupt_handler(unsigned long interrupt, signal_handler_t handler, void *userdata);
 
-enum error_t kernel_remove_interrupt_handler(unsigned long interrupt);
+error_t kernel_remove_interrupt_handler(unsigned long interrupt);
 
-enum error_t kernel_execute_interrupt_handler(unsigned long interrupt);
+error_t kernel_execute_interrupt_handler(unsigned long interrupt);
 
-enum error_t kernel_signal_return();
+error_t kernel_signal_return();
 
 int receive_message(struct message_t *buffer, int flags);
 

include/mmgr.h

@@ -3,6 +3,7 @@
 #include "memmap.h"
 #include "platform/paging.h"
 #include "types/physaddr.h"
+#include "types/status.h"
 #include <stddef.h>
 
 extern const size_t page_size;
@@ -71,7 +72,7 @@ void *page_map_end();
  * @param block_size 
  * @return enum error_t 
  */
-enum error_t initialize_page_map(struct memory_map_t *map, void *base, size_t memory_size, unsigned long block_size);
+error_t initialize_page_map(struct memory_map_t *map, void *base, size_t memory_size, unsigned long block_size);
 
 /**
  * @brief Create a new top-level page table and map the kernel in it.

include/queue.h

@@ -43,7 +43,7 @@ void queue_construct(struct queue_t *queue);
  * @param ptr A pointer to some user-defined data to store on the queue.
  * @return enum error_t
  */
-enum error_t queue_insert(struct queue_t *queue, void *ptr);
+error_t queue_insert(struct queue_t *queue, void *ptr);
 
 /**
  * @brief Removes the next item from the queue and returns it.

include/syscalls.h

@@ -1,15 +1,9 @@
 #pragma once
 
+#include "types/syscallarg.h"
 #include <stdbool.h>
 #include <stddef.h>
 
-typedef union
-{
-    long signed_int;
-    unsigned long unsigned_int;
-    void *ptr;
-} syscall_arg_t;
-
 typedef size_t (*syscall_ptr_0_t)();
 
 typedef size_t (*syscall_ptr_1_t)(syscall_arg_t);

include/types/physaddr.h

@@ -1,14 +1,6 @@
 #ifndef _QUARK_PHYSADDR_H
 #define _QUARK_PHYSADDR_H
 
-#include <stdint.h>
+typedef unsigned long int physaddr_t;
-
-#if defined __i386__ || __arm__
-typedef uint32_t physaddr_t;
-#elif defined __x86_64__ || __aarch64__
-typedef uint64_t physaddr_t;
-#else
-typedef uint64_t physaddr_t;
-#endif
 
 #endif

include/types/status.h

@@ -1,7 +1,7 @@
 #ifndef _QUARK_ERROR_H
 #define _QUARK_ERROR_H
 
-enum error_t
+typedef enum
 {
     ENONE = 0,
     ENULLPTR,
@@ -15,6 +15,6 @@ enum error_t
     EPERM,
     EBUSY,
     EEXITED
-};
+} error_t;
 
 #endif

include/types/syscallarg.h

@@ -0,0 +1,11 @@
+#ifndef _QUARK_SYSCALLARG_H
+#define _QUARK_SYSCALLARG_H
+
+typedef union
+{
+    long int signed_int;
+    unsigned long int unsigned_int;
+    void *ptr;
+} syscall_arg_t;
+
+#endif

include/types/syscallid.h

@@ -1,7 +1,7 @@
 #ifndef QUARK_SYSCALLID_H
 #define QUARK_SYSCALLID_H
 
-enum syscall_id_t
+typedef enum
 {
     SYSCALL_TEST = 1,
     SYSCALL_MMAP,
@@ -12,6 +12,6 @@ enum syscall_id_t
     SYSCALL_RECEIVE,
     SYSCALL_OPEN_PORT,
     SYSCALL_CLOSE_PORT
-};
+} syscall_id_t;
 
 #endif

include/x86/idt.h

@@ -32,11 +32,11 @@ enum interrupt_code_t
 
 enum isr_type_t
 {
-    INTERRPUT_TASK32 = 5,
+    INTERRUPT_TASK32 = 5,
-    INTERRPUT_TRAP32 = 15,
+    INTERRUPT_TRAP32 = 15,
-    INTERRPUT_INT32 = 14,
+    INTERRUPT_INT32 = 14,
-    INTERRPUT_TRAP16 = 7,
+    INTERRUPT_TRAP16 = 7,
-    INTERRPUT_INT16 = 6
+    INTERRUPT_INT16 = 6
 };
 
 void initialize_gdt();

src/Makefile.am

@@ -1,4 +1,4 @@
-noinst_PROGRAMS = quark-kernel
+bin_PROGRAMS = quark-kernel
 quark_kernel_SOURCES = kernel.c mmgr.c priorityqueue.c stdio.c string.c elf.c syscalls.c heap.c memmap.c avltree.c queue.c math.c
 quark_kernel_LDADD = -lgcc
 quark_kernel_CFLAGS = -I$(top_srcdir)/include -ffreestanding -mgeneral-regs-only -O0 -Wall -ggdb

src/heap.c

@@ -19,9 +19,9 @@ struct heap_t
 
 struct heap_node_t
 {
-    size_t height : 5;
     size_t mapped : 1;
     size_t state : 2;
+    size_t height : 5;
 } __attribute__ ((packed));
 
 size_t find_free_block(struct heap_t *heap, size_t height)

src/kernel.c

@@ -17,18 +17,19 @@ struct kernel_t kernel;
 
 void kernel_initialize(struct boot_info_t *boot_info)
 {
-    insert_region(&boot_info->map, (physaddr_t)&_kernel_pstart, (physaddr_t)&_kernel_pend - (physaddr_t)&_kernel_pstart, M_UNAVAILABLE);
-    initialize_page_map(&boot_info->map, (physaddr_t*)&_kernel_end, boot_info->memory_size, page_size);
-    kminit(&_kernel_start, page_map_end(), 0xFFC00000 - (size_t)&_kernel_start, 64);
     initialize_screen();
     printf("***%s***\n", PACKAGE_STRING);
     printf("Total memory: %08x\n", boot_info->memory_size);
+    printf("kernel: %08x ... %08x\n", &_kernel_pstart, &_kernel_pend);
     printf("Type\t\tLocation\t\tSize\n");
     for (size_t i = 0; i < boot_info->map.size && boot_info->map.array[i].size > 0; i++)
     {
         printf("%i\t\t\t%08x\t\t%u\n", boot_info->map.array[i].type, boot_info->map.array[i].location, boot_info->map.array[i].size);
     }
 
+    insert_region(&boot_info->map, (physaddr_t)&_kernel_pstart, (physaddr_t)&_kernel_pend - (physaddr_t)&_kernel_pstart, M_UNAVAILABLE);
+    initialize_page_map(&boot_info->map, (physaddr_t*)&_kernel_end, boot_info->memory_size, page_size);
+    kminit(&_kernel_start, page_map_end(), 0xFFC00000 - (size_t)&_kernel_start, 64);
     kernel.active_process = NULL;
     kernel.next_pid = 1;
     kernel.process_table = NULL;
@@ -62,7 +63,7 @@ void kernel_initialize(struct boot_info_t *boot_info)
     load_context(kernel_advance_scheduler());
 }
 
-enum error_t set_syscall(int id, int arg_count, int pid, void *func_ptr)
+error_t set_syscall(int id, int arg_count, int pid, void *func_ptr)
 {
     if(id < 0 || id > MAX_SYSCALL_ID)
     {
@@ -91,7 +92,7 @@ enum error_t set_syscall(int id, int arg_count, int pid, void *func_ptr)
     return ENONE;
 }
 
-size_t do_syscall(enum syscall_id_t id, syscall_arg_t arg1, syscall_arg_t arg2, syscall_arg_t arg3, void *pc, void *stack, unsigned long flags)
+size_t do_syscall(syscall_id_t id, syscall_arg_t arg1, syscall_arg_t arg2, syscall_arg_t arg3, void *pc, void *stack, unsigned long flags)
 {
     if(id < 0 || id > MAX_SYSCALL_ID)
     {
@@ -139,7 +140,7 @@ size_t do_syscall(enum syscall_id_t id, syscall_arg_t arg1, syscall_arg_t arg2,
     return result;
 }
 
-enum error_t kernel_load_module(struct module_t *module)
+error_t kernel_load_module(struct module_t *module)
 {
     physaddr_t module_address_space = create_address_space();
     if(module_address_space == ENOMEM) {
@@ -264,13 +265,13 @@ struct process_context_t *kernel_advance_scheduler()
     if(kernel.active_process != NULL)
     {
         paging_load_address_space(kernel.active_process->page_table);
-        printf("entering process %08x cr3=%08x ctx=%08x.\n", kernel.active_process->pid, kernel.active_process->page_table, kernel.active_process->ctx);
+        printf("entering process %08x cr3=%08x ctx=%08x sched=%i.\n", kernel.active_process->pid, kernel.active_process->page_table, kernel.active_process->ctx, kernel.priority_queue.size);
         return kernel.active_process->ctx;
     }
     panic("no processes available to enter!");
 }
 
-enum error_t kernel_terminate_process(size_t process_id)
+error_t kernel_terminate_process(size_t process_id)
 {
     struct process_t *process = avl_get(kernel.process_table, process_id);
     if(process == NULL)
@@ -298,7 +299,7 @@ enum error_t kernel_terminate_process(size_t process_id)
     return ENONE;
 }
 
-enum error_t kernel_store_active_context(struct process_context_t *context)
+error_t kernel_store_active_context(struct process_context_t *context)
 {
     if(kernel.active_process != NULL && kernel.active_process->ctx != NULL)
     {
@@ -311,7 +312,7 @@ enum error_t kernel_store_active_context(struct process_context_t *context)
     }
 }
 
-enum error_t kernel_create_port(unsigned long id)
+error_t kernel_create_port(unsigned long id)
 {
     if(avl_get(kernel.port_table, id) != NULL)
     {
@@ -325,7 +326,7 @@ enum error_t kernel_create_port(unsigned long id)
     return ENONE;
 }
 
-enum error_t kernel_remove_port(unsigned long id)
+error_t kernel_remove_port(unsigned long id)
 {
     struct port_t *port = avl_get(kernel.port_table, id);
     if(port == NULL)
@@ -355,7 +356,7 @@ unsigned long kernel_get_port_owner(unsigned long id)
     }
 }
 
-enum error_t kernel_send_message(unsigned long recipient, struct message_t *message)
+error_t kernel_send_message(unsigned long recipient, struct message_t *message)
 {
     struct process_t *dest = avl_get(kernel.process_table, recipient);
     if(dest == NULL)
@@ -383,7 +384,7 @@ enum error_t kernel_send_message(unsigned long recipient, struct message_t *mess
     }
 }
 
-enum error_t kernel_queue_message(unsigned long recipient, struct message_t *message)
+error_t kernel_queue_message(unsigned long recipient, struct message_t *message)
 {
     struct process_t *dest = avl_get(kernel.process_table, recipient);
     if(dest != NULL)
@@ -426,7 +427,7 @@ int receive_message(struct message_t *buffer, int flags)
     }
 }
 
-enum error_t kernel_register_interrupt_handler(unsigned long interrupt, signal_handler_t handler, void *userdata)
+error_t kernel_register_interrupt_handler(unsigned long interrupt, signal_handler_t handler, void *userdata)
 {
     if(avl_get(kernel.interrupt_handlers, interrupt) != NULL)
     {
@@ -440,17 +441,19 @@ enum error_t kernel_register_interrupt_handler(unsigned long interrupt, signal_h
     return ENONE;
 }
 
-enum error_t kernel_remove_interrupt_handler(unsigned long interrupt)
+error_t kernel_remove_interrupt_handler(unsigned long interrupt)
 {
-    if(avl_get(kernel.interrupt_handlers, interrupt) == NULL)
+    struct signal_action_t *action = avl_get(kernel.interrupt_handlers, interrupt);
+    if(action == NULL)
     {
         return EDOESNTEXIST;
     }
+    kfree(action);
     kernel.interrupt_handlers = avl_remove(kernel.interrupt_handlers, interrupt);
     return ENONE;
 }
 
-enum error_t kernel_execute_interrupt_handler(unsigned long interrupt)
+error_t kernel_execute_interrupt_handler(unsigned long interrupt)
 {
     struct signal_action_t *action = avl_get(kernel.interrupt_handlers, interrupt);
     if(action == NULL)
@@ -485,7 +488,7 @@ enum error_t kernel_execute_interrupt_handler(unsigned long interrupt)
     return ENONE;
 }
 
-enum error_t kernel_signal_return()
+error_t kernel_signal_return()
 {
     context_cleanup_func(kernel.active_process->ctx, 2);
     context_stack_pop(kernel.active_process->ctx, &kernel.active_process->state);

src/mmgr.c

@@ -54,7 +54,23 @@ struct page_map_t
     unsigned long free_block_count;
 } page_map;
 
-const int bitmap_word_size = 8 * sizeof(*page_map.bitmap);
+static const int bitmap_word_size = 8 * sizeof(*page_map.bitmap);
+
+static void clear_cache()
+{
+    for(int i = 0; i < MAX_CACHE_SIZE; i++)
+    {
+        page_map.cache[i] = 0;
+    }
+}
+
+static void clear_bitmap()
+{
+    for(int i = 0; i < page_map.bitmap_size / sizeof(*page_map.bitmap); i++)
+    {
+        page_map.bitmap[i] = 0;
+    }
+}
 
 int split_block(int index)
 {
@@ -88,7 +104,8 @@ int find_free_region(int height)
     {
         if(page_map.cache[page_map.height - height - llog2(bitmap_word_size)])
         {
-            unsigned long index = page_map.cache[page_map.height - height - llog2(bitmap_word_size)];
+            unsig6], [test $host = i686-elf])
+ned long index = page_map.cache[page_map.height - height - llog2(bitmap_word_size)];
             page_map.cache[page_map.height - height - llog2(bitmap_word_size)] = 0;
             return index;
         }
@@ -128,7 +145,10 @@ physaddr_t reserve_region(size_t size)
         int bitmap_index = index / bitmap_word_size;
         int bitmap_offset = index % bitmap_word_size;
         page_map.bitmap[bitmap_index] &= ~((unsigned long)1 << bitmap_offset);
-        return (page_map.block_size << height) * (index - ((unsigned long)1 << (page_map.height - height)));
+        physaddr_t page = (page_map.block_size << height) * (index - ((unsigned long)1 << (page_map.height - height)));
+        if(page < 0x10000)
+            ;//printf("Reserved %08x\n", page);
+        return page;
     }
     else
     {
@@ -149,7 +169,7 @@ int free_region(physaddr_t location, size_t size)
         unsigned long depth = llog2(index + 1) - 1;
         if(page_map.cache[depth - cache_start] == (index ^ 1))
         {
-            page_map.cache[depth - cache_start] = ENOMEM;
+            page_map.cache[depth - cache_start] = 0;
         }
         page_map.bitmap[bitmap_index] &= ~((unsigned long)1 << bitmap_offset);
         page_map.bitmap[bitmap_index] &= ~((unsigned long)1 << (bitmap_offset ^ 1));
@@ -191,7 +211,7 @@ void *page_map_end()
     return (void*)page_map.bitmap + page_map.bitmap_size;
 }
 
-enum error_t initialize_page_map(struct memory_map_t *map, void *base, size_t memory_size, unsigned long block_size)
+error_t initialize_page_map(struct memory_map_t *map, void *base, size_t memory_size, unsigned long block_size)
 {
     static unsigned long page_map_cache[MAX_CACHE_SIZE];
     // Round memory_size up to nearest power of 2
@@ -204,6 +224,8 @@ enum error_t initialize_page_map(struct memory_map_t *map, void *base, size_t me
     page_map.free_block_count = 0;
     int block_log = llog2(block_size);
     int pages_mapped = 0;
+    bool initialized = false;
+    printf("bmpsz: %08x bmploc: %08x\n", page_map.bitmap_size, page_map.bitmap);
     for(int i = 0; i < map->size; i++)
     {
         if(map->array[i].type != M_AVAILABLE)
@@ -212,65 +234,84 @@ enum error_t initialize_page_map(struct memory_map_t *map, void *base, size_t me
         }
         physaddr_t location = (map->array[i].location + page_size - 1) & ~(page_size - 1);
         physaddr_t region_end = map->array[i].location + map->array[i].size;
-        while(location + block_size <= region_end)
+        while(location + block_size <= region_end && pages_mapped < (page_map.bitmap_size + page_size - 1) / page_size)
         {
-            if(pages_mapped < page_map.bitmap_size / page_size)
+            void *page = (void*)page_map.bitmap + pages_mapped * page_size;
+            for(int level = 0; level < page_table_levels; level++)
             {
-                void *page = (void*)page_map.bitmap + pages_mapped * page_size;
+                if(!(get_pte_type(page, level) & PAGE_PRESENT))
-                for(int level = 0; level < page_table_levels; level++)
                 {
-                    if(!(get_pte_type(page, level) & PAGE_PRESENT))
+                    if(set_pte(page, level, PAGE_PRESENT | PAGE_RW, location))
                     {
-                        if(set_pte(page, level, PAGE_PRESENT | PAGE_RW, location))
+                        return ENOMEM;
-                        {
-                            return ENOMEM;
-                        }
-                        else if(level == page_table_levels - 1)
-                        {
-                            pages_mapped++;
-                        }
-                        break;
                     }
                     else if(level == page_table_levels - 1)
                     {
                         pages_mapped++;
                     }
+                    break;
+                }
+                else if(level == page_table_levels - 1)
+                {
+                    pages_mapped++;
                 }
-                location += page_size;
-                continue;
             }
+            location += page_size;
+            continue;
+        }
+
+        if(!initialized)
+        {
+            clear_bitmap();
+            initialized = true;
+        }
+
+        while(location + block_size <= region_end)
+        {
             int bit_offset = (location / block_size) % bitmap_word_size;
-            int bitmap_index = (location / block_size) / bitmap_word_size;
+            int bitmap_index = ((1 << (page_map.height - 0)) / bitmap_word_size) + (location / block_size) / bitmap_word_size;
             size_t chunk_size = (bitmap_word_size - bit_offset) * block_size;
+            // BUG: bitmap entries are uninitialized at first, never zeroed out
+            if(location < 0x180000)
+                printf("%08x ", page_map.bitmap[bitmap_index]);
             if(bit_offset == 0 && (region_end - location) >= chunk_size)
             {
+                if(location < 0x180000)
+                printf("a ");
                 // Set all bits in the word
                 page_map.bitmap[bitmap_index] = ~0;
             }
             else if(bit_offset == 0)
             {
+                if(location < 0x180000)
+                printf("b ");
                 // Set the first 'count' bits
                 int count = (region_end - location) >> block_log;
                 page_map.bitmap[bitmap_index] |= (1 << count) - 1;
             }
             else if((region_end - location) >= chunk_size)
             {
+                if(location < 0x180000)
+                printf("c ");
                 // Set all bits starting at 'bit_offset'
                 page_map.bitmap[bitmap_index] |= ~((1 << bit_offset) - 1);
             }
             else
             {
+                if(location < 0x180000)
+                printf("d ");
                 // Set all bits starting at 'bit_offset' up to 'count'
                 int count = (region_end - location) >> block_log;
                 page_map.bitmap[bitmap_index] |= ((1 << count) - 1) & ~((1 << bit_offset) - 1);
             }
+            if(location < 0x180000) {
+                printf("bmp: %08x loc: %08x end: %08x off: %i idx: %i cnt: %i\n", page_map.bitmap[bitmap_index], location, region_end, bit_offset, bitmap_index, (region_end - location) >> block_log);
+            }
+            
             location += chunk_size;
         }
     }
-    for(int i = 0; i < MAX_CACHE_SIZE; i++)
+    clear_cache();
-    {
-        page_map.cache[i] = 0;
-    }
     return ENONE;
 }
 

src/queue.c

@@ -23,7 +23,7 @@ void queue_construct(struct queue_t *queue)
     queue->count = 0;
 }
 
-enum error_t queue_insert(struct queue_t *queue, void *ptr)
+error_t queue_insert(struct queue_t *queue, void *ptr)
 {
     struct queue_node_t *node = kmalloc(sizeof(struct queue_node_t));
     if(node == NULL)

src/stdio.c

@@ -27,6 +27,7 @@ char *itoa(unsigned int n, unsigned int base, unsigned int width)
     static const char *digits = "0123456789abcdef";
     static char buffer[65];
     char *s = &buffer[64];
+    *s = 0;
     unsigned int count = 0;
     do
     {

src/syscalls.c

@@ -110,8 +110,8 @@ size_t send(syscall_arg_t recipient, syscall_arg_t message, syscall_arg_t flags)
             return EDOESNTEXIST;
         }
     }
-    enum error_t status = kernel_send_message(recipient.unsigned_int, message.ptr);
+    error_t status = kernel_send_message(recipient.unsigned_int, message.ptr);
-    if(status == EBUSY && op_type == IO_ASYNC)
+    if(status == EBUSY/* && op_type == IO_ASYNC*/)
     {
         return kernel_queue_message(recipient.unsigned_int, message.ptr);
     }

src/x86/idt.c

@@ -125,7 +125,7 @@ void load_tr(uint16_t gdt_offset)
 
 void create_interrupt_descriptor(struct interrupt_descriptor_t *descriptor, void *isr, enum isr_type_t type, uint32_t privilage, uint32_t selector)
 {
-    if(type != INTERRPUT_TASK32)
+    if(type != INTERRUPT_TASK32)
     {
         descriptor->offset_1 = (uint32_t) isr & 0xFFFF;
         descriptor->offset_2 = (uint32_t) isr >> 16;
@@ -245,15 +245,15 @@ void initialize_idt()
     memset(idt, 0, sizeof(struct interrupt_descriptor_t) * idt_size);
     for(int i = 0; i < idt_size; i++)
     {
-        create_interrupt_descriptor(&idt[i], (void*)isr_generic, INTERRPUT_INT32, 0, 8);
+        create_interrupt_descriptor(&idt[i], (void*)isr_generic, INTERRUPT_INT32, 0, 8);
     }
-    create_interrupt_descriptor(&idt[EXCEPTION_DIV_BY_0], (void*)isr_division_by_zero, INTERRPUT_INT32, 0, 8);
+    create_interrupt_descriptor(&idt[EXCEPTION_DIV_BY_0], (void*)isr_division_by_zero, INTERRUPT_INT32, 0, 8);
-    create_interrupt_descriptor(&idt[EXCEPTION_SEGMENT_NOT_PRESENT], (void*)isr_segment_not_present, INTERRPUT_TRAP32, 0, 8);
+    create_interrupt_descriptor(&idt[EXCEPTION_SEGMENT_NOT_PRESENT], (void*)isr_segment_not_present, INTERRUPT_TRAP32, 0, 8);
-    create_interrupt_descriptor(&idt[EXCEPTION_GPF], (void*)isr_gp_fault, INTERRPUT_TRAP32, 0, 8);
+    create_interrupt_descriptor(&idt[EXCEPTION_GPF], (void*)isr_gp_fault, INTERRUPT_TRAP32, 0, 8);
-    create_interrupt_descriptor(&idt[EXCEPTION_PAGE_FAULT], (void*)isr_page_fault, INTERRPUT_TRAP32, 0, 8);
+    create_interrupt_descriptor(&idt[EXCEPTION_PAGE_FAULT], (void*)isr_page_fault, INTERRUPT_TRAP32, 0, 8);
-    create_interrupt_descriptor(&idt[EXCEPTION_DOUBLE_FAULT], /*(void*)isr_double_fault*/NULL, INTERRPUT_TASK32, 0, 8 * 6);
+    create_interrupt_descriptor(&idt[EXCEPTION_DOUBLE_FAULT], /*(void*)isr_double_fault*/NULL, INTERRUPT_TASK32, 0, 8 * 6);
-    create_interrupt_descriptor(&idt[ISR_PREEMPT], (void*)isr_preempt, INTERRPUT_INT32, 3, 8);
+    create_interrupt_descriptor(&idt[ISR_PREEMPT], (void*)isr_preempt, INTERRUPT_INT32, 3, 8);
-    create_interrupt_descriptor(&idt[ISR_APIC_TIMER], (void*)isr_timer, INTERRPUT_INT32, 0, 8);
+    create_interrupt_descriptor(&idt[ISR_APIC_TIMER], (void*)isr_timer, INTERRUPT_INT32, 0, 8);
-    create_interrupt_descriptor(&idt[ISR_SYSCALL], (void*)isr_syscall, INTERRPUT_INT32, 3, 8);
+    create_interrupt_descriptor(&idt[ISR_SYSCALL], (void*)isr_syscall, INTERRUPT_INT32, 3, 8);
     load_idt(idt);
 }

src/x86/multiboot2.c

@@ -107,9 +107,12 @@ void *read_multiboot_table_entry(struct boot_info_t *boot_info, void *table)
             boot_info->modules[boot_info->module_count].start = ((struct multiboot2_module_t*) table)->start;
             boot_info->modules[boot_info->module_count].end = ((struct multiboot2_module_t*) table)->end;
             strcpy(boot_info->modules[boot_info->module_count].str, &((struct multiboot2_module_t*) table)->str);
+            unsigned long size = ((struct multiboot2_module_t*) table)->end - ((struct multiboot2_module_t*) table)->start;
+            size += 4095;
+            size &= ~4095;
             insert_region(&boot_info->map, 
                 ((struct multiboot2_module_t*) table)->start, 
-                ((struct multiboot2_module_t*) table)->end - ((struct multiboot2_module_t*) table)->start, 
+                size, 
                 M_UNAVAILABLE);
             boot_info->module_count++;
         }

src/x86/paging.c

@@ -2,6 +2,7 @@
 #include "string.h"
 
 #include <stddef.h>
+#include <stdint.h>
 
 struct page_table_entry_t
 {